This repository has been archived by the owner on Jan 4, 2024. It is now read-only.
Add ignition support #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
…mat is "ignition"
1 task
bavarianbidi
approved these changes
Jul 13, 2022
|
out of curiosity: which container-runtime is flatcar using per default? Do we have to explicity set the path to the socket? |
|
It's using containerd https://github.com/giantswarm/cluster-openstack/pull/85/files#diff-5d5883ddf8c1c53c57998dd4e264ba16884f7052542e6aaac0b5764c644985a7R20-R27 It's image-builder job to install it. |
|
Good work 👍 |
fiunchinho
reviewed
Jul 21, 2022
| kubeadm_file="/run/kubeadm/kubeadm.yaml" | ||
| fi | ||
|
|
||
| cat "${dir}/gs-kube-proxy-config.yaml" >> "${dir}/kubeadm.yaml" |
There was a problem hiding this comment.
fiunchinho
reviewed
Jul 21, 2022
| @@ -9,7 +9,8 @@ set -o errexit | |||
| set -o nounset | |||
| set -o pipefail | |||
|
|
|||
| readonly dir="/run/kubeadm" | |||
| dir=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd ) | |||
| readonly dir | |||
|
|
|||
| # Run this script only if this is the init node. | |||
| if [[ ! -f ${dir}/kubeadm.yaml ]]; then | |||
There was a problem hiding this comment.
I understood this file was present only on flatcar. Would this work on Ubuntu? If the file is not present on Ubuntu the script will do nothing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#778
Tested scenarios: