Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateAnnotatedFile property #139

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aoisupersix
Copy link

Fixes #131

This PR adds updateAnnotatedFile property to @OpenApi() annotation.

When the timestamp is forcibly added or updated to the @OpenApi() annotated class, frequent differences occur in source control. Therefore, by adding the updateAnnotatedFile property, if false is set, the addition or update of the timestamp will not be performed.

@Openapi(
  ...
  updateAnnotatedFile: false,
)

Default is true to keep current behavior.

The operation was checked by uncommenting in openapi-generator/pubspec.yaml.

# dependency_overrides:
#  openapi_generator_annotations:
#    path: ../openapi-generator-annotations

@Rick-VA
Copy link

Rick-VA commented Apr 5, 2024

We tested it on 5 APIs, and it worked perfectly. Thanks

@DmitrySboychakov
Copy link

Also interested in this. When this can be merged?

@tjarvstrand
Copy link

Great change! Please merge :)

@aoisupersix
Copy link
Author

This PR is blocked because it requires a review from a user with write permissions.
Also the package update process will likely be necessary after merge.
Therefore need to wait for owner (@gibahjoe) to respond.

139

@tjarvstrand
Copy link

@aoisupersix Yes, sorry, my comment was meant for @gibahjoe :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generator adds comment into version controlled source file containing the Openapi annotation
6 participants