Manifest was depending on undefined behavior #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling (find-class x) where x is not a symbol is undefined behavior.
Calling (find-class x) where x isn't a symbol is undefined behavior
|
Hi - could you take a look at this pull request? |
|
This is issue #10, which I had actually fixed in my fork ages ago, but somehow never pushed a PR for. In any case, I endorse this PR … a mere 5 years later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(find-class x) where x isn't a symbol is undefined behavior.
It broke manifest for clasp - a new Common Lisp implementation.