Add support for AWS STS Tokens in S3 Backend #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Duplicacy Forum. There might be relevant details there: https://forum.duplicacy.com/t/s3-backend-support-for-aws-session-token-sts/1426/2 |
|
@gilbertchen is there a chance to get this merged in the next release? Or even that you give me feedback on behavior you want to have changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support temporary AWS Credentials, issued by calls to
sts:assumeRole[1].This feature was already requested a long time ago in the Duplicacy Forum [2].
It adds a new backend variant
s3-token://in order to be compatible with existing use cases.If this is desired to be merged I'd be happy to contribute the necessary adjustments to the docs aswell.
[1] AWS STS Assume Role Docs
[2] Duplicacy Forum: S3 Backend - Support for AWS_SESSION_TOKEN (STS)