-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
4986beb
commit a43df63
Showing
3 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a43df63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgive the random comment, but why don't you use git tags? It makes upgrading singlefile a pain for anyone that doesn't want to blindly point to HEAD=master branch.
a43df63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, that's mostly for legacy reason (the CLI is relatively recent) and because I'm too lazy. I'll try to tag future versions.
a43df63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, I don't know about lazy, but you are consistent in using "bump version" :)
so you could run smth like this to make history forget you're lazy ;)
would run
and then you can
git push --tags
a43df63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! That should be okay now.
I wished the "Releases" would be displayed on the GH page though.
Edit: it's also fixed :)
a43df63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant! Thanks!
PS: yeah, I guess you've figured out that github wants "releases" to be annotated tags
a43df63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it was just a setting issue. I just had to click on the cogwheel icon next to "About" to re-enable it.