Adopt ngx-translate standalone API in demo project #166
+90
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ruizmarc
commented
Nov 18, 2024
•
ruizmarc
commented
- Adopt ngx-translate standalone API in demo project
- Update to Angular 18.2 and later update to Angular 19
- Also includes: refactor: replace deprecated ConnectableObservable by share
chore: update angular ssr and ng-packagr
|
Updating PR to include Angular 19 demo project migration |
vrady
reviewed
Dec 8, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@gilsdav/ngx-translate-router", | |||
| "version": "7.2.1", | |||
| "version": "7.2.2", | |||
There was a problem hiding this comment.
Let’s update the version to 8.0.0, as the library now utilizes ngx-translate v16 and Angular v19.
There was a problem hiding this comment.
It’s backwards compatible, no breaking changes, just following semantic versioning
| | 15 | 6.0.0 | 2.0.0 | legacy | minimum angular 15.0.3 | | ||
| | 15.1 | 6.1.0 | 2.0.0 | legacy | minimum angular 15.1.0 | | ||
| | 16 | 7.0.0 | 2.0.0 | legacy | minimum angular 16 | | ||
| | 17 | 7.1.0 | 2.0.0 | legacy | optional standalone API | | ||
| | 18 | 7.2.1 | 2.0.0 | active | | | ||
|
|
There was a problem hiding this comment.
Maybe add smth like this?
| 19 | 8.0.0 | 2.0.0 | active | ngx-translate v16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.