Replace Context::new with Loader::new
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
force-pushed
the
issue-253
branch
5 times, most recently
from
5bc13ee
to
0b6d301
Compare
The Loader encapsulates the process of loading the DWARF data and keeping it alive so that the Context can refer to it. It also handles tasks such as loading dSYM or DWO files. This allows us to remove the `object` crate from the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Loader encapsulates the process of loading the DWARF data and keeping it alive so that the Context can refer to it. It also handles tasks such as loading dSYM or DWO files.
This allows us to remove the
objectcrate from the public API.Closes #253