revert PR #46 #61
Merged
revert PR #46 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the `strconv` import in `timeout_test.go` - Remove the `TestWriter_Status` test function in `timeout_test.go` - Remove the `Status` method in `writer.go` Signed-off-by: Bo-Yi Wu <[email protected]>
- Remove an empty line in `timeout_test.go` Signed-off-by: Bo-Yi Wu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 92.91% 95.08% +2.16%
==========================================
Files 4 4
Lines 127 122 -5
==========================================
- Hits 118 116 -2
+ Misses 6 4 -2
+ Partials 3 2 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
appleboy
force-pushed
the
timeout
branch
2 times, most recently
from
866e287
to
8ad3412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strconvimport intimeout_test.goTestWriter_Statustest function intimeout_test.goStatusmethod inwriter.gocc @zhyee