Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: binding time with empty value #4098 #4103

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ksw2000
Copy link

@ksw2000 ksw2000 commented Nov 21, 2024

Fixes: #4098
In setTimeField, when the string val is empty and the timeFormat is unix or unixnano, an error occurs due to strconv.ParseInt handling empty values. We can handle this by filling it with a zero value before parsing.

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binding time.Time with empty value returns error
1 participant