Get rid of boundary edges in the database #28
Conversation
dkhofer
force-pushed
the
remove-boundary-edges
branch
from
0e1152d
to
c141e85
Compare
| @@ -360,6 +360,7 @@ fn main() { | |||
| sample, | |||
| }) => { | |||
| let mut conn = get_connection(db); | |||
| conn.execute("PRAGMA cache_size=50000;", []).unwrap(); | |||
There was a problem hiding this comment.
This dropped the benchmark timing from 11s to 8.5-9s
| "INSERT OR IGNORE INTO block_group_edges (block_group_id, edge_id) VALUES {0};", | ||
| formatted_rows_to_insert | ||
| ); | ||
| let _ = conn.execute(&insert_statement, ()); |
There was a problem hiding this comment.
do we even need a nassignment?
There was a problem hiding this comment.
The rust compiler gives a warning if I don't have it, because execute may return an Err value. It seems like the shortest way of saying "yes, I actually mean to ignore the return value".
src/models/block_group.rs
Outdated
| } | ||
|
|
||
| #[allow(clippy::len_zero)] | ||
| if block_boundaries.len() > 0 { |
There was a problem hiding this comment.
guessing thi swants you to use .empty() instead of len?
There was a problem hiding this comment.
Yeah, but I just tried again and it worked. I think I was in a rush and tried is_empty instead of !is_empty, which caused tests to break. I think at that point I had been fixing compiler and formatting errors for a while and just got fed up with it. Thanks for asking about this, it's fixed now
| for (into, out_of) in sorted_sequence_edges.clone().into_iter().tuple_windows() { | ||
| let start = into.target_coordinate; | ||
| let end = out_of.source_coordinate; | ||
| for (start, end) in block_boundaries.clone().into_iter().tuple_windows() { |
There was a problem hiding this comment.
this is nice to know we have, i was just doing the other way for zipping lists
dkhofer
force-pushed
the
remove-boundary-edges
branch
from
edae1c9
to
e89724d
Compare
No description provided.