Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build/test actions #3

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Add build/test actions #3

merged 5 commits into from
Jul 22, 2024

Conversation

dkhofer
Copy link
Collaborator

@dkhofer dkhofer commented Jul 22, 2024

No description provided.

@dkhofer dkhofer requested a review from Chris7 July 22, 2024 20:27
Chris7
Chris7 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@Chris7 Chris7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we need to explciit build

.github/workflows/test.yml Outdated

steps:
- uses: actions/checkout@v4
- name: Build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think test auto builds

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, I autogenerated this file using the github web UI and it included the build part. Removed

@dkhofer dkhofer merged commit a210525 into main Jul 22, 2024
1 check passed
@Chris7 Chris7 deleted the add-test-action branch August 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris7 Chris7 Chris7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkhofer @Chris7