app: [js] fix tabbing #116
Conversation
Signed-off-by: Egon Elbre <[email protected]>
Signed-off-by: Egon Elbre <[email protected]>
│ sec/op │ sec/op vs base │ SplitCubic/4-10 37.36n ± 0% 36.16n ± 0% -3.21% (p=0.000 n=10) SplitCubic/8-10 74.53n ± 0% 72.21n ± 0% -3.12% (p=0.000 n=10) SplitCubic/16-10 149.3n ± 1% 144.5n ± 0% -3.22% (p=0.000 n=10) SplitCubic/33-10 340.1n ± 0% 334.4n ± 0% -1.65% (p=0.000 n=10) Signed-off-by: Egon Elbre <[email protected]>
Signed-off-by: inkeliz <[email protected]>
Signed-off-by: inkeliz <[email protected]>
| if e.focused { | ||
| key.SoftKeyboardOp{Show: true}.Add(gtx.Ops) | ||
| } |
There was a problem hiding this comment.
Can you expand the commit message to say what issue this fixes? Is there a TODO number?
There was a problem hiding this comment.
Without that change TAB on browser will switch the focus to another input (which is expected!), but the focus is removed, in the next frame.
Currently, on JS, Gio focus/blur one input based on SoftKeyboardOp, even on desktop.
Previously, SoftKeyboardOp is requested using requestFocus, which happens only after clicking into the input. However, when the focus shifts to another input without clicking (which is the tabbing case): it don't triggers requestFocus, then it doesn't use SoftKeyboardOp.
There was a problem hiding this comment.
This losing of focus after TAB sounds like a browser-only issue, correct? If so, can it be fixed in os_js.go so Editor doesn't need to know?
whereswaldon
force-pushed
the
main
branch
4 times, most recently
from
0d543a0 to
1686874
Compare
whereswaldon
force-pushed
the
main
branch
2 times, most recently
from
67c77c9 to
46cc311
Compare
whereswaldon
force-pushed
the
main
branch
2 times, most recently
from
f8029f2 to
026d3f9
Compare
whereswaldon
force-pushed
the
main
branch
12 times, most recently
from
e8ba786 to
4e2d418
Compare
No description provided.