Only run publish workflow on release #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to give this a shot. As far as I'm understanding it I need to push a This is fine for now, but in the future we should really automate this and publish/release once the changelog in the main branch has changed. (example of how we did that for the ionide analyzers, the tl;dr is that we extract the changelog version via https://github.com/ionide/KeepAChangelog and just compare with previous version) |
nojaf
approved these changes
Aug 8, 2024
|
Sounds like a good idea. I'll give it a try next weekend. 👍 |
|
Cool, tremendous thanks for all your work on this and for letting us have this repository in this organization! The NuGet package was published to https://www.nuget.org/packages/Giraffe.OpenApi //cc @dungpa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
publish.ymlworkflow to run only when a new release is published. I've removed the triggers for pull requests and pushes to the main branch, focusing the workflow solely on the release process.Note: With this change, someone with the necessary permissions will need to create a new tag or release to trigger the publish workflow. This ensures that we only publish new versions of Giraffe.OpenApi when explicitly releasing a new version.