Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): use custom wix template to avoid update removing shortcuts #5280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(windows): use custom wix template to avoid update removing shortcuts #5280

wants to merge 1 commit into from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Oct 23, 2024 •
edited
Loading

☕️ Reasoning

  • Use custom windows wix template to control how installing/updating handles the existing shortcuts, specifically these lines:
<InstallExecuteSequence>
    <RemoveShortcuts>Installed AND NOT UPGRADINGPRODUCTCODE</RemoveShortcuts>
</InstallExecuteSequence>

🧢 Changes

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:00am

@github-actions github-actions bot added the rust Pull requests that update Rust code label Oct 23, 2024
@ndom91 ndom91 force-pushed the fix-windows-taskbar-shortcut branch 2 times, most recently from b628043 to 710bffa Compare October 23, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ndom91