-
Notifications
You must be signed in to change notification settings - Fork 568
Use assignment creator's token when random token fails #2286
base: master
Are you sure you want to change the base?
Conversation
Update since today is my last day 😢 I held off on this PR since I found some weird behavior testing it locally. To reproduce:
This might be some weird issues on my environment. Once this is fixed I suggest adding this under a feature flag to be safe. |
I've been getting my local environment to test the weird behavior Eric mentioned. So far I haven't reproduced it (the assignment was successfully accepted) but will keep trying tomorrow. |
I dug around in the console and it looks like the |
Rather than creating a fake Instead of changing which
|
What
Back-end solution to #2222
When creating a repo for a student, grab a random classroom admin's token (as we currently do).
If the token can access the repo, use that token to create the student repo. Otherwise use the assignment creator's token.