Merge pull request #2158 from github/autocompletebox-fix

Modernizing and Implementing Autocompletebox
github · Apr 10, 2019 · 0b5badb · 0b5badb
2 parents f8cfdae + 76ebd75
commit 0b5badb
Show file tree

Hide file tree

Showing 57 changed files with 1,188 additions and 1,310 deletions.
diff --git a/src/GitHub.App/Caches/AutoCompleteSourceCache.cs b/src/GitHub.App/Caches/AutoCompleteSourceCache.cs
diff --git a/src/GitHub.App/Caches/IAutoCompleteSourceCache.cs b/src/GitHub.App/Caches/IAutoCompleteSourceCache.cs
diff --git a/src/GitHub.App/Caches/IIssuesCache.cs b/src/GitHub.App/Caches/IIssuesCache.cs
diff --git a/src/GitHub.App/Caches/IMentionsCache.cs b/src/GitHub.App/Caches/IMentionsCache.cs
diff --git a/src/GitHub.App/Caches/IssuesCache.cs b/src/GitHub.App/Caches/IssuesCache.cs
diff --git a/src/GitHub.App/Caches/MentionsCache.cs b/src/GitHub.App/Caches/MentionsCache.cs
diff --git a/src/GitHub.App/Models/SuggestionItem.cs b/src/GitHub.App/Models/SuggestionItem.cs
@@ -1,4 +1,5 @@
 using System;
+using GitHub.Extensions;
 using GitHub.Helpers;
 
 namespace GitHub.Models
@@ -9,36 +10,22 @@ namespace GitHub.Models
     /// </summary>
     public class SuggestionItem
     {
-        public SuggestionItem() // So this can be deserialized from cache
-        {
-        }
-
-        public SuggestionItem(string name, Uri iconCacheKey)
-        {
-            Ensure.ArgumentNotNullOrEmptyString(name, "name");
-            Ensure.ArgumentNotNull(iconCacheKey, "iconCacheKey");
-
-            Name = name;
-            IconKey = iconCacheKey;
-        }
-
         public SuggestionItem(string name, string description)
         {
-            Ensure.ArgumentNotNullOrEmptyString(name, "name");
-            Ensure.ArgumentNotNullOrEmptyString(description, "description");
+            Guard.ArgumentNotEmptyString(name, "name");
+            Guard.ArgumentNotEmptyString(description, "description");
 
             Name = name;
             Description = description;
         }
 
-        public SuggestionItem(string name, string description, Uri iconCacheKey)
+        public SuggestionItem(string name, string description, string imageUrl)
         {
-            Ensure.ArgumentNotNullOrEmptyString(name, "name");
-            Ensure.ArgumentNotNull(iconCacheKey, "iconCacheKey");
+            Guard.ArgumentNotEmptyString(name, "name");
 
             Name = name;
             Description = description;
-            IconKey = iconCacheKey;
+            ImageUrl = imageUrl;
         }
 
         /// <summary>
@@ -52,9 +39,9 @@ public SuggestionItem(string name, string description, Uri iconCacheKey)
         public string Description { get; set; }
 
         /// <summary>
-        /// A key to lookup when displaying the icon for this entry
+        /// An image url for this entry
         /// </summary>
-        public Uri IconKey { get; set; }
+        public string ImageUrl { get; set; }
 
         /// <summary>
         /// The date this suggestion was last modified according to the API.