C#: Extraction Integration Tests for Blazor #18325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egregius313
added
the
no-change-note-required
egregius313
force-pushed
the
egregius313/csharp/blazor/basic-integration-tests
branch
from
9f311b8 to
a03b232
Compare
There was a problem hiding this comment.
Copilot reviewed 60 out of 75 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/BlazorTest.csproj: Language not supported
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/Layout/MainLayout.razor.css: Language not supported
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/Layout/NavMenu.razor.css: Language not supported
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Properties/launchSettings.json: Language not supported
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/appsettings.json: Language not supported
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/global.json: Language not supported
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/wwwroot/app.css: Language not supported
- csharp/ql/integration-tests/all-platforms/blazor/Files.expected: Language not supported
- csharp/ql/integration-tests/all-platforms/blazor/Files.ql: Language not supported
- csharp/ql/integration-tests/all-platforms/blazor/htmlSinks.expected: Language not supported
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/App.razor: Evaluated as low risk
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/Layout/MainLayout.razor: Evaluated as low risk
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/Layout/NavMenu.razor: Evaluated as low risk
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/MyInput.razor: Evaluated as low risk
- csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/MyOutput.razor: Evaluated as low risk
Comments suppressed due to low confidence (1)
csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/Pages/TestPage.razor:92
- [nitpick] The constant XssUrl2 is named ambiguously. It should be renamed to something more descriptive like
SanitizedXssUrl.
private const string XssUrl2 = "<b>aaaa</b>";
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
| // Configure the HTTP request pipeline. | ||
| if (!app.Environment.IsDevelopment()) | ||
| { | ||
| app.UseExceptionHandler("/Error", createScopeForErrors: true); |
There was a problem hiding this comment.
The method 'UseExceptionHandler' does not have a parameter 'createScopeForErrors'. This should be removed or corrected.
Suggested change
| app.UseExceptionHandler("/Error", createScopeForErrors: true); | |
| app.UseExceptionHandler("/Error"); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| public string? Value { get; set; } = ""; | ||
| } | ||
|
|
||
| private const string XssUrl = "<b>aaaa<%2Fb>"; |
There was a problem hiding this comment.
The constant XssUrl contains an invalid HTML tag (<%2Fb>), which might cause rendering issues. Consider correcting the tag.
Suggested change
| private const string XssUrl = "<b>aaaa<%2Fb>"; | |
| private const string XssUrl = "<b>aaaa</b>"; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
egregius313
force-pushed
the
egregius313/csharp/blazor/basic-integration-tests
branch
from
b936ffb to
ba84896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies the integration test from #17355 and adds variants for .NET 8, .NET 9, and
build-mode: nonedatabases.I have temporarily removed the dataflow queries from the integration test as I am not ready to merge those pieces yet.
Pull Request checklist
All query authors
- [ ] All new queries have appropriate.qhelp. See the documentation in this repository.- [ ] QL tests are added if necessary. See Testing custom queries in the GitHub documentation.- [ ] New and changed queries have correct query metadata. See the documentation in this repository.Internal query authors only
- [ ] Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to.ql,.qll, or.qhelpfiles. See the documentation (internal access required).- [ ] Changes are validated at scale (internal access required).- [ ] Adding a new query? Consider also adding the query to autofix.