C++: Fix types of struct/union templates and fix assumptions on proxy classes #18483
+9,724
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
added
the
depends on internal PR
jketema
force-pushed
the
extractor-fixes
branch
3 times, most recently
from
522e5f7 to
9846322
Compare
jketema
commented
Jan 13, 2025
|
|
||
| bindingset[kind] | ||
| int getKind(int kind) { | ||
| if kind in [10, 11, 12] |
There was a problem hiding this comment.
Rows with 10, 11, 12 should not have been generated for a long time. However, before this PR there's no upgrade script that replaces these numbers with something within the used range of numbers. This means we could not remove any references to 10, 11, and 12. By adding this to this upgrade script we can now remove those references.
jketema
commented
Jan 13, 2025
| @@ -771,12 +771,13 @@ decltypes( | |||
|
|
|||
| /* | |||
| case @usertype.kind of | |||
| 1 = @struct | |||
| | 0 = @unknown_usertype | |||
There was a problem hiding this comment.
0 was used in practice already, so this just makes its use explicit.
jketema
force-pushed
the
extractor-fixes
branch
from
b9693fa to
27242ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).