Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure API is capitalized in service FQNs. #15

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Ensure API is capitalized in service FQNs. #15

merged 2 commits into from
Feb 8, 2024

Conversation

patrickt
Copy link
Contributor

@patrickt patrickt commented Feb 7, 2024 •
edited
Loading

This addresses a bug introduced by #13.

@patrickt patrickt requested a review from a team as a code owner February 7, 2024 19:36
jorendorff
jorendorff requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@jorendorff jorendorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh there's a field for this already in prost-build

jorendorff
jorendorff approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@jorendorff jorendorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@patrickt patrickt merged commit 163edf9 into main Feb 8, 2024
1 check passed
@patrickt patrickt deleted the patrickt/fix-fqns branch February 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorendorff jorendorff jorendorff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickt @jorendorff