Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explict add image field in devcontainer.json #194

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Explict add image field in devcontainer.json #194

merged 2 commits into from
Dec 1, 2023

Conversation

trganda
Copy link
Contributor

@trganda trganda commented Nov 30, 2023 •
edited
Loading

For detail, see #193

aeisenberg
aeisenberg reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening. Looks reasonable. Just a question.

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@trganda
Copy link
Contributor Author

trganda commented Dec 1, 2023

Thanks for opening. Looks reasonable. Just a question.

Tks, I have accepted it.

aeisenberg
aeisenberg approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@aeisenberg aeisenberg merged commit 996e4b3 into github:main Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trganda @aeisenberg