This repository has been archived by the owner on May 12, 2018. It is now read-only.
Alter way to check for running runners by using PID file #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChristianRiesen I think we use 2 spaces in GitLab for indention, can you please fix that? |
|
Sure, will do. Small addition, I found that google seems to prefer 2 spaces for shell scripts as well: |
|
@jvanbaarsen Fixed and ready. |
|
👍 Looking forward to see this get merged :) |
|
@randx Looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check_pid function has been changed to go over the pids in the pid file and see if there are running processes with those ids. This also makes pull request #66 superflous.
All other changes are purely whitespace (tabs to 4 spaces). It was a mess all over so I just cleaned that up.