Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

update rspec to 3.1 #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skv-headless
Copy link
Contributor

No description provided.

commit.should be_kind_of Gitlab::Git::Commit
hunk_lines.first.should == "# Contribute to GitLab"
expect(commit).to be_kind_of Gitlab::Git::Commit
hunk_lines.first == "# Contribute to GitLab"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

it { tag.message.should == "Release" }
it { tag.name == "v1.0.0" }
it { tag.target == "f4e6814c3e4e7a0de82a9e7cd20c626cc963a2f8" }
it { tag.message == "Release" }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

it { blob.name.should == "russian.rb" }
it { blob.data.lines.first.should == "Хороший файл" }
it { blob.size.should == 23 }
it { blob.name == "russian.rb" }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 46f7ba2 on skv-headless:update_rspec into d6c3928 on gitlabhq:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants