Tests and new cli args #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-hanna
commented
Aug 20, 2024
•
adam-hanna
commented
- Adds verify signature
- Adds Multi-sign
- Adds batch sign and batch multi-sign
- Adds tests
added 10 commits
August 14, 2024 16:11
adam-hanna
commented
Sep 3, 2024
| _, err = TxValidateSignaturesExec(s.clientCtx, s.keyringDir, signedTxFile.Name()) | ||
| s.Require().NoError(err) | ||
|
|
||
| // TODO: modifying the tx and verifying isn't working. It always passes when it should fail... |
There was a problem hiding this comment.
@giunatale modifying the transaction and re-verifying should result in an error but does not. I assume this is because local verification doesn't check tx data and needs to be connected to a node?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.