Skip to content

Commit

Permalink
TravisCI fixes.
Browse files Browse the repository at this point in the history
  • Loading branch information
gjb2048 committed Mar 3, 2016
1 parent a434e7b commit a5de6c9
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
1 change: 1 addition & 0 deletions Changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Version 2.8.4
6. Put back word-break on section-title.
7. Change edit summary to edit section on cog icon to be consistent.
8. Fix 'Managers assigned at Course Category levels cannot change topcoll settings until course exists' - #24.
9. TravisCI fixes.

Version 2.8.3.1
1. Fixed #22, Orphaned sections are not responsive.
Expand Down
4 changes: 2 additions & 2 deletions format.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ M.course.format.swap_sections = function(Y, node1, node2) {
};

var sectionlist = Y.Node.all(CSS.COURSECONTENT + ' ' + M.course.format.get_section_selector(Y));
// Swap menus
// Swap menus.
sectionlist.item(node1).one(CSS.SECTIONADDMENUS).swap(sectionlist.item(node2).one(CSS.SECTIONADDMENUS));
};

Expand All @@ -90,7 +90,7 @@ M.course.format.process_sections = function(Y, sectionlist, response, sectionfro
};

if (response.action === 'move') {
if (sectionfrom > sectionto) { // MDL-34798
if (sectionfrom > sectionto) { // MDL-34798.
var temp = sectionto;
sectionto = sectionfrom;
sectionfrom = temp;
Expand Down
14 changes: 7 additions & 7 deletions module.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ M.format_topcoll.ourYUI = false;
M.format_topcoll.numSections = 0;
M.format_topcoll.ie8 = false;

// Namespace constants:
// Namespace constants:....
M.format_topcoll.TOGGLE_6 = 1;
M.format_topcoll.TOGGLE_5 = 2;
M.format_topcoll.TOGGLE_4 = 4;
Expand Down Expand Up @@ -217,7 +217,7 @@ M.format_topcoll.save_toggles = function() {
}
};

// New base 64 code:
// New base 64 code:....
M.format_topcoll.is_old_preference = function(pref) {
"use strict";
var retr = false;
Expand Down Expand Up @@ -290,12 +290,12 @@ M.format_topcoll.get_toggle_pos = function(togglenum) {

M.format_topcoll.get_min_digit = function() {
"use strict";
return ':'; // 58 ':';
return ':'; // ':' is 58.
};

M.format_topcoll.get_max_digit = function() {
"use strict";
return 'y'; // 58 'y';
return 'y'; // 'y' is 121.
};

M.format_topcoll.get_toggle_flag = function(togglenum, togglecharpos) {
Expand Down Expand Up @@ -352,9 +352,9 @@ M.format_topcoll.set_user_preference = function(name, value) {

// If we are a developer, ensure that failures are reported.
var cfg = {
method: 'get',
on: {}
};
method: 'get',
on: {}
};
if (M.cfg.developerdebug) {
cfg.on.failure = function() {
console.log("Error updating topcoll preference '" + name + "' using AJAX. Almost certainly your session has timed out. Clicking this link will repeat the AJAX call that failed so you can see the error: "); // jshint ignore:line
Expand Down
2 changes: 1 addition & 1 deletion togglelib.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class topcoll_togglelib {

// Digits used = ":;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`abcdefghijklmnopqrstuvwxy";
// Note: An ':' is 58 Ascii so to go between six digit base 2 and this then add / subtract 58.
// This has been chosen to avoid digits which are in the old method.
// This has been chosen to avoid digits which are in the old method.

const TOGGLE_6 = 1;
const TOGGLE_5 = 2;
Expand Down

0 comments on commit a5de6c9

Please sign in to comment.