Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude 'aria-readonly' in localSettings selector #1554

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Exclude 'aria-readonly' in localSettings selector #1554

merged 1 commit into from
Aug 12, 2023

Conversation

alexisquintero
Copy link
Contributor

What this PR is trying to fix: given https://github.com/glacambre/firenvim/blob/master/tsconfig.json as an example, clicking in the code will trigger firenvim to start an nvim instance. This should not happen, the textarea can't be edited

Tested manually first with the default values

document.querySelectorAll('textarea:not([readonly]), div[role="textbox"]')

and with

document.querySelectorAll('textarea:not([readonly], [aria-readonly]), div[role="textbox"]')

Tested locally by building the extension with DOCKER_BUILDKIT=1 docker build . -t firenvim --output target

Closes #1537

@glacambre
Copy link
Owner

This is great, thanks a lot for taking the time to do this! I must admit that I was a bit annoyed by this but never really took the time to dig into fix it :)

@glacambre glacambre merged commit 5d27ebf into glacambre:master Aug 12, 2023
16 of 18 checks passed
@alexisquintero alexisquintero deleted the aria-readonly branch August 13, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants