Exclude 'aria-readonly' in localSettings selector #1554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR is trying to fix: given https://github.com/glacambre/firenvim/blob/master/tsconfig.json as an example, clicking in the code will trigger firenvim to start an nvim instance. This should not happen, the textarea can't be edited
Tested manually first with the default values
and with
Tested locally by building the extension with
DOCKER_BUILDKIT=1 docker build . -t firenvim --output target
Closes #1537