Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable arbitrary writes #1606

Merged
merged 2 commits into from
Apr 28, 2024
Merged

enable arbitrary writes #1606

merged 2 commits into from
Apr 28, 2024

Conversation

glacambre
Copy link
Owner

  • firenvim.vim: filter out g:firenvim_config objects that can't be json
  • Add firenvim#write() function enabling users to write arbitrary data

@glacambre glacambre force-pushed the enable_arbitrary_writes branch 3 times, most recently from 52f8acb to 8480e4a Compare April 28, 2024 13:46
@glacambre glacambre force-pushed the enable_arbitrary_writes branch 2 times, most recently from 59c4539 to d996c46 Compare April 28, 2024 14:00
@glacambre
Add firenvim#write() function enabling users to write arbitrary data
67a7fa2 
The goal of this commit is to enable the use case desired by #1589. This
isn't a perfect fit as the user was asking for a way to setup
post-processing of their text instead of having to call firenvim#write,
but as I am on a tight schedule for publishing a new release I do not
have time for further discussions, and following the pattern of
firenvim#hide_frame, firenvim#eval_js, firenvim#focus_* feels like a
very safe choice.
@glacambre glacambre merged commit 236ea75 into master Apr 28, 2024
15 of 19 checks passed
@glacambre glacambre deleted the enable_arbitrary_writes branch April 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glacambre