Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light extension linting #1607

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Light extension linting #1607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
911f45c
package.json: add lint step to lint firefox extension
glacambre Apr 28, 2024
44f825f
FirenvimElement.ts: use s/browser.extension/browser.runtime/
glacambre Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"install_manifests": "nvim --headless -u NORC -i NONE -n -c \":set rtp+=.\" -c \"call firenvim#install(1)\" -c \"quit\"",
"jest": "jest",
"nyc": "nyc",
"lint": "addons-linter target/xpi/firefox-latest.xpi",
"pack": "web-ext build --source-dir target/firefox --artifacts-dir target/xpi --overwrite-dest",
"tests": "npm run test-firefox && npm run test-chrome",
"test-firefox": "webpack --env=firefox-testing && nyc instrument --in-place target/firefox && web-ext build --source-dir target/firefox --artifacts-dir target/xpi --overwrite-dest && jest firefox",
Expand Down
2 changes: 1 addition & 1 deletion src/FirenvimElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export class FirenvimElement {
})(this));
this.resizeObserver.observe(this.getElement(), { box: "border-box" });

this.iframe.src = (browser as any).extension.getURL("/index.html");
this.iframe.src = (browser as any).runtime.getURL("/index.html");
this.span.attachShadow({ mode: "closed" }).appendChild(this.iframe);

// So pages (e.g. Jira, Confluence) remove spans from the page as soon
Expand Down
Loading