Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-41] - Fix Batch Control Override and Update Company Identification to Alphanumeric #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martinsd94
Copy link

Issue: #41

Overview:

This PR resolves two key issues:

  1. Batch Control Override Fix: Corrects the batch control override logic.
  2. Company Identification Update: Updates the companyIdentification field to support alphanumeric values, in line with modern NACHA practices that allow for greater flexibility.

Details:

  • The NACHA Company Identification field was originally designed to be numeric, often using the Employer Identification Number (EIN) prefixed with a "1". However, as ACH payments expanded and proprietary codes became more common, financial institutions started to support alphanumeric Company IDs. This change accommodates different identification schemes, making it easier for various types of originators to comply.

Changes:

  • Batch Control Fix: Fix batch control override logic.
  • Company ID Update: Adjusted the type for companyIdentification field to allow alphanumeric characters, reflecting current standards.

Please review and merge if appropriate! :)

@martinsd94
Copy link
Author

Hi @glenselle @yawetse @reillywatson @chevett 👋,
can you check this PR?

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant