Add support for returning bounds of entire scroll area #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jassmith
reviewed
Oct 5, 2023
jassmith
reviewed
Oct 5, 2023
jassmith
reviewed
Oct 5, 2023
jassmith
requested changes
Oct 5, 2023
jassmith
reviewed
Oct 5, 2023
jassmith
reviewed
Oct 5, 2023
jassmith
added a commit
that referenced
this pull request
Nov 26, 2023
* 5.3.1-alpha1 * Fix issue where data grid would not understand headers were not hovered when mouse over the rightElement * Update prettier * Modernize tooling * Don't escape for commas, not needed * Fix eslint * 5.3.1-alpha2 * Improve naming of escape function * Fix fuzzy drag handles, fixes #741 * Fix tests * Resolve issue where editing would accidentally check the wrong cell for read/write. * restore cyce checking * Ensure onCellClicked and renderer onClick events fire under the same conditions, fixes #690 * Fix paste eating some new lines * 5.3.1-alpha3 * Fix clicking on scrollbars, fixes #762 * Hopefully fix source tests * Implement cut and fix crasher in paste * Fix cells tests * Fix formatting issue with uri cells * Add tests * Overhaul copy/paste code to dramatically improve accuracy, compatibility, and remove accidentally encoding nbsp into users apps * Fix an insane crash report * Add a couple tests * Increase test coverage * Add more missing tests * More missing tests * Fix issue with apple numbers paste buffers * Fix typo * Add more tests * More tests for image window loader * Add distribution test * Add support for returning bounds of entire scroll area (#788) * Support returning bounds of entire scroll area * Add scale to calculation * Apply PR feedback * Fix check * Additional fix * Fix docs --------- Co-authored-by: Lukas Masuch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough draft of how the entire scroll bounds could be returned via
getBoundsifcellandroware undefined (see #784). I did some manual testing, and it seems to align well with what is returned bygetBoundsfor specific items. The height differs by one pixel when compared with the last cell bounds. But that is probably the border that is also included in the scroll area.