Convert to regular spaces in decodeHTML
#804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious to know when this fix will go out. |
|
This should be fixed already in 5.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/glideapps/glide/issues/23589
When pasting
text/htmlcontent, we generate a DOM fragment and thendecodeHTMLwalks that DOM, reading out the text values of cells. During this process, regular space characters are converted into non-breaking space Unicode characters, which can cause subtle and annoying issues if, for instance the pasted text is re-copied out of GDG.This PR modifies
decodeHTMLto normalize the strings it reads from the DOM by replacing the non-breaking space characters with regular spaces.