Add support for DNS SRV lookups #341
Conversation
mhamann
force-pushed
the
master
branch
3 times, most recently
from
45e7db1 to
1c9ae3a
Compare
|
@michaelshobbs it took me far longer to complete this than I originally intended, but at last, it is ready to go. :-) |
mhamann
force-pushed
the
master
branch
2 times, most recently
from
a3f99c4 to
96b908c
Compare
|
No worries. Thanks for the contribution |
|
@michaelshobbs what do you need before this can be merged? |
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file. | |||
| ### Fixed | |||
|
|
|||
| ### Added | |||
| - @mhamann: Enabled DNS SRV lookups for all transports (e.g. lookups via Consul) | |||
There was a problem hiding this comment.
This section is just a template for the release process. Please remove this line. I'll summarize all changes upon release.
|
@michaelshobbs can this get merged please? |
|
this PR has merge conflicts. happy to merge once the feedback and conflicts are resolved. |
|
@ChrisLahaye I've since moved my environment to Kubernetes. Between k8s services and kube-dns, I no longer need SRV lookups. I believe I'd originally resolved conflicts and addressed review comments, but I guess it must've fallen through the cracks. Not sure I'll have time to fix this up again, but would be happy for someone else to handle it. Seems like it would still be a good contribution. |
Fixes #270