[BUGFIX] Fix reactivity of dynamic attributes #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updates to use autotracking through the VM resulted in a bug in dynamic attributes. Previously, the updating opcode for dynamic attributes would run its update function based on tags/autotracking - whenever any tag updated (e.g. a tracked value was changed) the attribute would call its `update` function. The `update` function would then check the new value against the current value of the attribute, and update if they were different. The bug was we introduced a value comparison in the updating opcode itself, based on the last value of the property to set the attribute to. This meant that if the property was updated to the same value twice in a row, it would not call `update`, even if the attribute's value had changed (e.g. because the user typed something).
|
FYI - This is a backport of #1268 into the branch used by [email protected]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updates to use autotracking through the VM resulted in a bug in
dynamic attributes. Previously, the updating opcode for dynamic
attributes would run its update function based on tags/autotracking -
whenever any tag updated (e.g. a tracked value was changed) the
attribute would call its
updatefunction. Theupdatefunction wouldthen check the new value against the current value of the attribute, and
update if they were different.
The bug was we introduced a value comparison in the updating opcode
itself, based on the last value of the property to set the attribute to.
This meant that if the property was updated to the same value twice in
a row, it would not call
update, even if the attribute's value hadchanged (e.g. because the user typed something).