Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make feature discovery lazy #1538

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Make feature discovery lazy #1538

merged 1 commit into from
Dec 24, 2023

Commits on Dec 24, 2023

  1. Make feature discovery lazy 

    While working toward [strict-es-modules](emberjs/rfcs#938), I found that under real ES modules, this feature-detection code will become eager, which makes it blow up inside all versions of ember-cli-htmlbars before ember-cli/ember-cli-htmlbars#786, because ember-cli-htmlbars insists on evaluating the template compiler bundle inside a VM with no valid `URL` global.

While that is now fixed in an upcoming major of ember-cli-htmlbars, people can't benefit from that until their very last addon upgrades ember-cli-htmlbars.

So it's also good to fix this directly, by making the feature detection code explicitly lazy.
    @ef4
    ef4 committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    e266bf9 View commit details
    Browse the repository at this point in the history