Rewrite comments in training configuration to be more newbie friendly #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # either the policy head or value head should be emphasized by the | ||
| # gradient descent, relative to each other and to the regularization | ||
| # (where regularization helps keep weights closer to 0, which helps | ||
| # the network to generalize better to novel positions) |
There was a problem hiding this comment.
I don't really understand the relationship between boundaries and value, or when a particular value is selected based on the boundary. Maybe include an example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inspired by my own painful learning over the last couple of weeks. These comments are what I've learned, and would have saved me and everyone who answered my questions the trouble.