Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream up to 425d77f8124a50fc033e8fb3bdf7b89a6a25f4fa #2365

Merged
merged 31 commits into from
Aug 12, 2023

Conversation

ClearlyClaire
Copy link

As explained in #2363 (comment), I find it easier to do the merge/port PRs myself. That being said, thanks @Plastikmensch for #2363, this has been (and will continue to be) helpful for triaging commits to port/skip/postpone

Conflicts

  • .rubocop_todo.yml:
    Upstream regenerated this file, glitch-soc had a specific ignore.
  • README.md:
    Upstream updated its README, but glitch-soc has a completely different one.
    Kept glitch-soc's README

Postponed changes:

Ported changes

Skipped changes

c960657 and others added 30 commits July 28, 2023 23:02
…oc/merge-upstream

Conflicts:
- `.rubocop_todo.yml`:
  Upstream regenerated this file, glitch-soc had a specific ignore.
- `README.md`:
  Upstream updated its README, but glitch-soc has a completely different one.
  Kept glitch-soc's README
…king, capitalization and autocomplete

Port 71fd703 to glitch-soc

Signed-off-by: Claire <[email protected]>
@Plastikmensch
Copy link

As explained in #2363 (comment), I find it easier to do the merge/port PRs myself. That being said, thanks @Plastikmensch for #2363, this has been (and will continue to be) helpful for triaging commits to port/skip/postpone

Glad it was helpful :3
I could maintain a list (in an issue or so) of upstream commits which could be ported and which need to be postponed, if that's something that would help you.

One clarification question though: Does "port PRs" also mean porting already postponed changes?

@ClearlyClaire
Copy link
Author

I could maintain a list (in an issue or so) of upstream commits which could be ported and which need to be postponed, if that's something that would help you.

It is useful! It's also very useful to point commits to already-open issues!

One clarification question though: Does "port PRs" also mean porting already postponed changes?

Yeah also, although it's a little more self-contained and so a little easier to maintain.

@Plastikmensch
Copy link

Plastikmensch commented Aug 11, 2023

It is useful! It's also very useful to point commits to already-open issues!

Can do!
I'm a bit unsure if I should create one issue and keep updating it, or create a new one after every upstream merge.
(The latter would be a bit less spammy with references and keep the backreferences useful, but has the disadvantage of not really working well with partial merges)

Yeah also, although it's a little more self-contained and so a little easier to maintain.

Okay, then I'll probably stop doing those.

@ClearlyClaire ClearlyClaire merged commit 0dfc6ea into glitch-soc:main Aug 12, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants