Callback to handle HPP response + HPP_VERSION 2 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* You can handle lightbox initiation yourself * Handle hpp response manually via callback instead of fire & forget post to merchant url * UMD-ify the modules, for use with webpack/browserify/etc
+ Strip `null` from hpp json + normalise whitespace + add index.js entry point for npm
At some display resolutions, changes in iframe contents (e.g. validation errors/scrollbars), can receive multiple resize messages getting taller & narrower, until it's 0px wide
…nsions (e.g. lastpass)
simonflk
changed the title
|
Shame this isn't merged I really wanna use this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a need for a more bespoke solution for hosted payments than your SDK currently provides.
This PR adds the following features by adding an addition function,
setup()(naming isn't one of my strengths 😄)messagelistener, so rxp-js can be used multiple times in an app lifecycle without leakingIn doing this, I've done some small refactoring, to allow me to reuse functions, and also added UMD, so it can be more easily used with build tools such as webpack & browserify.
I was going to add unit tests for rx-hpp.js, but I found this very difficult to test because of the tight-coupling with the DOM, and the fact that the
RxpLightboxis private, and therefore impossible to mock.