Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚇🧹 Move requirements_min.txt into .github folder so it won't picked up by dependabot #286

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Aug 25, 2024

This hopefully prevents PRs from dependabot where it tries to update the minimum version (e.g. see this PR).

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner August 25, 2024 15:21
Copy link
Contributor

sourcery-ai bot commented Aug 25, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/dependabot-ignore-min-versions

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.84%. Comparing base (b880df9) to head (3f5b888).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   44.77%   42.84%   -1.94%     
==========================================
  Files          27       28       +1     
  Lines        1043     1146     +103     
  Branches      162      184      +22     
==========================================
+ Hits          467      491      +24     
- Misses        568      647      +79     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsnel jsnel merged commit 00954eb into glotaran:main Aug 25, 2024
32 checks passed
@s-weigand s-weigand deleted the dependabot-ignore-min-versions branch September 20, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants