Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹🚇 Fix PR benchmark workflow #1344

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Aug 27, 2023

Currently, ASV benchmarks are failing with the following error message:

Couldn't load asv.plugins.mamba because
No module named 'mamba'
Couldn't load asv.plugins.virtualenv because
No module named 'packaging'
· Unknown environment type 'virtualenv'
· No environments selected

Where virtualenv is our configured environment_type.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@s-weigand s-weigand requested a review from a team as a code owner August 27, 2023 19:40
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/fix-asv

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1e260f4) 88.5% compared to head (162aabf) 88.5%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1344   +/-   ##
=====================================
  Coverage   88.5%   88.5%           
=====================================
  Files        107     107           
  Lines       5128    5128           
  Branches     962     962           
=====================================
  Hits        4542    4542           
  Misses       471     471           
  Partials     115     115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2023

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.7.1 vs. main

All benchmarks:

| Change   | Before [535acaaa] <v0.7.1>   | After [69c1d3bc]    |   Ratio | Benchmark (Parameter)                   |
|----------|------------------------------|---------------------|---------|-----------------------------------------|
|          | 216M                         | 219M                |    1.01 | IntegrationTwoDatasets.peakmem_optimize |
|          | 1.75±0.03s                   | 1.75±0.04s          |    1    | IntegrationTwoDatasets.time_optimize    |

Benchmark diff main vs. PR

All benchmarks:

| Change   | Before [69c1d3bc]    | After [162aabf4]    |   Ratio | Benchmark (Parameter)                   |
|----------|----------------------|---------------------|---------|-----------------------------------------|
|          | 219M                 | 215M                |    0.98 | IntegrationTwoDatasets.peakmem_optimize |
|          | 1.75±0.04s           | 1.72±0.03s          |    0.98 | IntegrationTwoDatasets.time_optimize    |

@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@s-weigand s-weigand requested a review from jsnel August 28, 2023 20:02
Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@s-weigand s-weigand merged commit 8df8ec5 into glotaran:main Aug 29, 2023
34 checks passed
@s-weigand s-weigand deleted the fix-asv branch August 29, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants