Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add official numpy 2 support #1503

Merged
merged 3 commits into from
Aug 25, 2024
Merged

✨ Add official numpy 2 support #1503

merged 3 commits into from
Aug 25, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 26, 2024

Bumps numpy from 1.26.4 to 2.0.1.

Release notes

Sourced from numpy's releases.

v2.0.1

NumPy 2.0.1 Release Notes

NumPy 2.0.1 is a maintenance release that fixes bugs and regressions discovered after the 2.0.0 release. NumPy 2.0.1 is the last planned release in the 2.0.x series, 2.1.0rc1 should be out shortly.

The Python versions supported by this release are 3.9-3.12.

NOTE: Do not use the GitHub generated "Source code" files listed in the "Assets", they are garbage.

Improvements

np.quantile with method closest_observation chooses nearest even order statistic

This changes the definition of nearest for border cases from the nearest odd order statistic to nearest even order statistic. The numpy implementation now matches other reference implementations.

(gh-26656)

Contributors

A total of 15 people contributed to this release. People with a "+" by their names contributed a patch for the first time.

  • @​vahidmech +
  • Alex Herbert +
  • Charles Harris
  • Giovanni Del Monte +
  • Leo Singer
  • Lysandros Nikolaou
  • Matti Picus
  • Nathan Goldbaum
  • Patrick J. Roddy +
  • Raghuveer Devulapalli
  • Ralf Gommers
  • Rostan Tabet +
  • Sebastian Berg
  • Tyler Reddy
  • Yannik Wicke +

Pull requests merged

A total of 24 pull requests were merged for this release.

  • #26711: MAINT: prepare 2.0.x for further development
  • #26792: TYP: fix incorrect import in ma/extras.pyi stub
  • #26793: DOC: Mention '1.25' legacy printing mode in set_printoptions
  • #26794: DOC: Remove mention of NaN and NAN aliases from constants

... (truncated)

Commits
  • 4c9f431 Merge pull request #27000 from charris/prepare-2.0.1
  • 0e70e00 REL: Prepare for the NumPy 2.0.1 release [wheel build]
  • 4d10ffc Merge pull request #26995 from charris/backport-26985
  • 764b667 BUG: Add object cast to avoid warning with limited API
  • 9be6ad6 Merge pull request #26971 from charris/backport-26935
  • 6d950e9 BUG: fix f2py tests to work with v2 API
  • 89630c0 Merge pull request #26962 from charris/backport-26919
  • 88fa840 TST: Apply test suggestion by Nathan for rlstrip fixes
  • a9da01e BUG,MAINT: Fix utf-8 character stripping memory access
  • 6afbbf8 Merge pull request #26963 from charris/backport-26930
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
numpy [>= 1.25.a, < 1.26]

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner July 26, 2024 18:50
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jul 26, 2024
@dependabot dependabot bot requested a review from a team as a code owner July 26, 2024 18:50
@dependabot dependabot bot requested review from jsnel and s-weigand July 26, 2024 18:50
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch glotaran/pyglotaran/dependabot/pip/numpy-2.0.1

Copy link
Contributor

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.7.2 vs. main

All benchmarks:

| Change   | Before [1fb14bbc] <v0.7.2>   | After [dc92e964]    |   Ratio | Benchmark (Parameter)                   |
|----------|------------------------------|---------------------|---------|-----------------------------------------|
|          | 237M                         | 237M                |       1 | IntegrationTwoDatasets.peakmem_optimize |
|          | 1.48±0.06s                   | 1.47±0.04s          |       1 | IntegrationTwoDatasets.time_optimize    |

Benchmark diff main vs. PR

All benchmarks:

| Change   | Before [dc92e964]    | After [04ec95fb]    |   Ratio | Benchmark (Parameter)                   |
|----------|----------------------|---------------------|---------|-----------------------------------------|
|          | 237M                 | 239M                |    1.01 | IntegrationTwoDatasets.peakmem_optimize |
|          | 1.47±0.04s           | 1.45±0.1s           |    0.99 | IntegrationTwoDatasets.time_optimize    |

@s-weigand
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 23, 2024

A newer version of numpy exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@s-weigand
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 23, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Bumps [numpy](https://github.com/numpy/numpy) from 1.26.4 to 2.0.1.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.26.4...v2.0.1)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@s-weigand s-weigand changed the title Bump numpy from 1.26.4 to 2.0.1 ✨ Official numpy 2 support Aug 25, 2024
@s-weigand s-weigand changed the title ✨ Official numpy 2 support ✨ Add official numpy 2 support Aug 25, 2024
This caused the following test error:
```py
FAILED glotaran/utils/test/test_io.py::test_create_clp_guide_dataset_errors - assert "Unknown clp_...'species_3')]" == "Unknown clp_... 'species_3']"

  Skipping 49 identical leading characters in diff, use -v to show
    ls are:
  -  ['species_1', 'species_2', 'species_3']
  +  [np.str_('species_1'), np.str_('species_2'), np.str_('species_3')]
```
Copy link

sonarcloud bot commented Aug 25, 2024

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting times ahead with the 2nd major version of numpy!

@jsnel jsnel merged commit fcaab51 into main Aug 25, 2024
36 checks passed
@jsnel jsnel deleted the dependabot/pip/numpy-2.0.1 branch August 25, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants