Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Element Result Saving #1534

Open
wants to merge 12 commits into
base: staging
Choose a base branch
from

Commits on Jul 6, 2024

  1. Configuration menu
    Copy the full SHA
    745d7d3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f4cc3c View commit details
    Browse the repository at this point in the history
  3. Rename back to number_of_clps

    Which is more consistent with 0.7 API
    jsnel committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    0b202c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Configuration menu
    Copy the full SHA
    0884198 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Update flake.

    joernweissenborn committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    3ffacca View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    c2dc7cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    542a67f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9fe832d View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Fix issues constructing svd

    Forward port of
    
    🩹 Fix prepare_dataset's add_svd_to_dataset function (glotaran#1522)
    jsnel committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    95b318e View commit details
    Browse the repository at this point in the history
  2. 🩹Fix wrong order of arguments in OptimizationObjectiveResult

    by making each init use named arguments
    jsnel committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    eeec5e5 View commit details
    Browse the repository at this point in the history
  3. 🩹⌨️ Fix mypy issues

    This fix relies on assert to narrow down types.
    However using more uniform interfaces would be a more desirable way to solve this, but this is out of scope for a review fix.
    s-weigand committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    d10fac4 View commit details
    Browse the repository at this point in the history
  4. Rename datavars in result_dataset to be plural

    _associated_amplitude_ -> _associated_amplitudes_
    _associated_concentration_ -> _associated_concentrations_
    jsnel committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    f41fd12 View commit details
    Browse the repository at this point in the history