-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Element Result Saving #1534
Open
joernweissenborn
wants to merge
12
commits into
glotaran:staging
Choose a base branch
from
joernweissenborn:staging_1474
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+779
−497
Commits on Jul 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 745d7d3 - Browse repository at this point
Copy the full SHA 745d7d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f4cc3c - Browse repository at this point
Copy the full SHA 0f4cc3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b202c6 - Browse repository at this point
Copy the full SHA 0b202c6View commit details
Commits on Jul 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0884198 - Browse repository at this point
Copy the full SHA 0884198View commit details
Commits on Jul 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3ffacca - Browse repository at this point
Copy the full SHA 3ffaccaView commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c2dc7cd - Browse repository at this point
Copy the full SHA c2dc7cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 542a67f - Browse repository at this point
Copy the full SHA 542a67fView commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 9fe832d - Browse repository at this point
Copy the full SHA 9fe832dView commit details
Commits on Sep 14, 2024
-
Forward port of 🩹 Fix prepare_dataset's add_svd_to_dataset function (glotaran#1522)
Configuration menu - View commit details
-
Copy full SHA for 95b318e - Browse repository at this point
Copy the full SHA 95b318eView commit details -
🩹Fix wrong order of arguments in OptimizationObjectiveResult
by making each init use named arguments
Configuration menu - View commit details
-
Copy full SHA for eeec5e5 - Browse repository at this point
Copy the full SHA eeec5e5View commit details -
This fix relies on assert to narrow down types. However using more uniform interfaces would be a more desirable way to solve this, but this is out of scope for a review fix.
Configuration menu - View commit details
-
Copy full SHA for d10fac4 - Browse repository at this point
Copy the full SHA d10fac4View commit details -
Rename datavars in result_dataset to be plural
_associated_amplitude_ -> _associated_amplitudes_ _associated_concentration_ -> _associated_concentrations_
Configuration menu - View commit details
-
Copy full SHA for f41fd12 - Browse repository at this point
Copy the full SHA f41fd12View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.