Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for maximal_[centered|]_bounded_sphere #224

Open
janbridley opened this issue May 28, 2024 · 0 comments
Open

Update docs for maximal_[centered|]_bounded_sphere #224

janbridley opened this issue May 28, 2024 · 0 comments

Comments

@janbridley
Copy link
Collaborator

Feature description

Confusion often arises between the maximal bounded sphere and the minimal bounding sphere.

Proposed solution

The docs for these properties should be updated to be more specific. Perhaps graphical examples could be given to clarify the confusing wording. insphere_from_center (the previous property name) is perhaps more misleading - an "insphere", which by Coxeter's definition must be tangent to every face, is not the same as the general bounded sphere discussed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant