Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port msd to pure python #1279

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Port msd to pure python #1279

merged 6 commits into from
Sep 17, 2024

Conversation

DomFijan
Copy link
Contributor

@DomFijan DomFijan commented Sep 11, 2024

As part of the nanobind port msd submodule must be ported to pure python.

Description

msd submodule has been ported to pure python.

Motivation and Context

As part of the nanobind port msd submodule must be ported to pure python.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@DomFijan DomFijan marked this pull request as ready for review September 11, 2024 15:02
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joaander joaander merged commit 4a789ce into nanobind Sep 17, 2024
26 checks passed
@joaander joaander deleted the port_msd branch September 17, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants