Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WorkspaceClientCapabilities to match LSP specification #281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snowsignal
Copy link

The diagnostic field on WorkspaceClientCapabilities is actually supposed to be called diagnostics. This can be confirmed in the LSP specification.

Screenshot 2024-04-16 at 6 41 18 PM

A consequence of this mis-naming is that DiagnosticWorkspaceClientCapabilities are never de-serialized, and diagnostic will always be None. That's why it needs to be changed to diagnostics.

… the specification, `WorkspaceClientCapabilities::diagnostics`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant