feat: Remove deprecated API from JavaFX 23 #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the title to follow pre-defined format |
jperedadnr
changed the title
|
Done, thought I'm not sure "feature" is the right one for this issue. |
Oliver-Loeffler
requested changes
Sep 28, 2024
There was a problem hiding this comment.
Ideally there is a test, showing that this is working as intended. The test should not reflect the exact class and package structure from Scene Builder kit but it shoud kind of demonstrate how CSS handling works and how the different CSS classes play together. May be a new test package such as com.oracle.javafx.scenebuilder.kit.tests.css could be a good starting point.
kit/src/main/java/com/oracle/javafx/scenebuilder/kit/util/CssInternal.java
Show resolved
Hide resolved
Oliver-Loeffler
approved these changes
Sep 29, 2024
kit/src/main/java/com/oracle/javafx/scenebuilder/kit/util/CssInternal.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #726
Progress