Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.sh #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kalebskeithley
Copy link
Contributor

whatever cleans the workspace where the tree is cloned apparently just does rm -rf * which does not delete .foo, and in particular the .python-shebangs file from previous build in this workspace

whatever cleans the workspace where the tree is cloned apparently just does `rm -rf *` which does not delete .foo, and in particular the .python-shebangs file from previous build in this workspace
@nigelbabu
Copy link
Contributor

I'd like to add this to the code that actually does the clean up rather than here. That's in build-jobs on Gerrit.

@kalebskeithley
Copy link
Contributor Author

kalebskeithley commented Aug 30, 2018

That'd be my preference too. I looked for something like that, but it's too well hidden. So you fixed it there already? (Where ever that is?)

And I can't find anything named build-jobs in gerrit. (I see the build-job task in jenkins.)

I see the cleanup.sh script that cleans most things. Do we really just keep cloning into the same directory without ever doing an rm -rf * (and an rm -rf .*) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants