Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create castle-ruins.svg #57

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Create castle-ruins.svg #57

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 20, 2017

First proposed version of a ruins icon (see issues)

This is my first git-hub action. Hope, I did everything right.

@nebulon42
Copy link
Member

Thanks for this PR! Could you please separate each icon into its own PR? This makes it easier to discuss each design separately, since there is not much overlap between the themes.

You would do that by creating a branch from master for each icon and then commit the icon separately to its branch and create a pull request for each icon.

Please also make sure that you save the output of Inkscape as "Plain SVG" as detailed in https://github.com/gmgeo/osmic/blob/master/CONTRIBUTING.md#technical-aspects

Since you mentioned that you are not too familiar with GitHub yet, here are some resources to help you with that:

https://guides.github.com/introduction/flow/
https://gist.github.com/blackfalcon/8428401

On guides.github.com GitHub has other resources that might be of value. The second link assumes that you are using the command line client of Git, which seems a bit difficult first, but really isn't hard to do. If you have any questions, please feel free to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant