Improve compatibility of dispensersToggleThings
by optionally using Fabric API's stub players
#302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #283.
This PR makes Carpet Extra use Fabric API's new stub players (confusingly called
FakePlayer
in the API) fordispensersToggleThings
if the API is available. Otherwise, it keeps usingnull
and handlingnull
where vanilla doesn't.The API access is done via a constant MethodHandle that will directly either call the api or return null. Constant MethodHandles can even be inlined to a plain call, so this should ensure no performance loss vs directly calling the api.
Vs #283, this:
I'll hold on merging until this last point is resolved in Fabric API, but otherwise this is ready.