Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the gametest framework and add a few tests #320

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Conversation

altrisi
Copy link
Collaborator

@altrisi altrisi commented Jun 25, 2024

Adds the framework to add gametests to Carpet Extra, and a few tests.

Now clean of hacks!

Useful to know for development commands and findings about them:

  • Use /test export to export nearby structure blocks to test ready snbt files
    You don't even need to hit save on the block, it'll do it for you. Here's the different ones I've found useful:
    • exportclosest: The best, just exports the one form the structure block closest to you
    • exportthat: Exports "the one you're looking at". Sounds nice, but often doesn't work properly
    • export <name>: This one does need the structure to be saved I believe, and exports by name
    • exportthese: Exports all in quite a big radius. Don't use it, especially if you've ran tests given it'll run save on the modified blocks
  • /test run of course
  • /test verify seems to run them all in different places and orientations to ensure they work even if you move them
  • /test pos to find the relative position inside a structure box (of the targeted block)
  • tbh just check the /test command

Progress for #319, this PR won't complete it all.

@altrisi
Copy link
Collaborator Author

altrisi commented Jun 26, 2024

Was told the proper way, changed pretty much all of the framework I had done, and ended up removing all but a single line other than Gradle. Pushing changes in a bit.

Only loss is having to restart to add a new class, but it wasn't that
useful anyway (couldn't reload). And many things got better
@altrisi altrisi marked this pull request as ready for review June 26, 2024 17:39
@altrisi altrisi changed the title WIP gametests Use the gametest framework and add a few tests Jun 26, 2024
@altrisi altrisi mentioned this pull request Jun 26, 2024
44 tasks
@altrisi
Copy link
Collaborator Author

altrisi commented Jun 26, 2024

Will add it to GHA in later.

@altrisi altrisi merged commit 0a6c551 into master Jun 26, 2024
2 checks passed
@altrisi altrisi deleted the gametest-wip branch June 26, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant