-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added lifetime tracker #156
base: staging
Are you sure you want to change the base?
Conversation
My goodness that's a lot of code! Before I start reviewing it properly, can you reindent your added files with 4 spaces rather than tabs? |
Ahhh right I forgot that, one second |
ported from Carpet TIS Addition 1.20.0
07845d1
to
f9677df
Compare
done, btw if you search tab character in the carpet package there are some mixing tabs tho xd |
I haven't started reviewing it yet as well, but one simple thoguth so far. I'm not sure the trackers should be under the |
Yeah it should, commands is only for the interface with the user |
Now all lifetime tracker stuffs are moved to the |
Ported from Carpet TIS Addition v1.20.0, code modified from TISCarpet13
Doc: https://github.com/TISUnion/TISCarpet113/blob/TIS-Server/docs/Features.md#lifetime
Codes
All related classes of lifetime tracker are in package
carpet.commands.lifetime
See the change files for more details
Carpet
commandLifeTime
with default valuetrue
/lifetime
commandcarpet.CarpetServer#onLoadAllWorlds
c
inMessanger
class for easier portingMinecraft
All modification to the minecraft codes are commented with
// CM lifetime tracker
WorldServer
andEntity
for the trackerEntitySelector
public for/lifetime filter
sub commandIssue
Due to mob being able to spawn outside of the spawning sphere, mobs with DESPAWN_IMMEDIATELY removal reason might spam in the statistic. It can be fixed with rule
optimizedDespawnRange
enabledShowcase