Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] wayland: Use full buffer for wayland viewport source #1115

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

kamplom
Copy link
Contributor

@kamplom kamplom commented Mar 20, 2024

Prevents the client from crashing when using factorial scaling in Wayland. See libsdl-org/SDL#9283 (comment) for technical explanation.
Fixes #1113. Tested with hyprland and plasma on wayland.

@gnif
Copy link
Owner

gnif commented Mar 21, 2024

Thanks but you need to make a few changes.

  1. This project has adopted an 80 column width limit, please adjust your patch to conform to this.
  2. Please add yourself to the AUTHORS file as a requirement of contributing.
  3. Please adjust the commit format to conform with the project, in this case it should read [client] wayland: ...

@kamplom kamplom changed the title Use full buffer for wayland viewport source [client] wayland: Use full buffer for wayland viewport source Mar 21, 2024
@gnif
Copy link
Owner

gnif commented Mar 21, 2024

I am sorry, while you have made the requested changes it has been done improperly.

  1. Please squash your changes into a single commit (hint: git rebase -i)
  2. Please adjust the comment message of your changes, not the title of this issue (hint: git commit --amend)

As this is a fork of the project you can force push to it (git push -f) which will update this PR accordingly

@kamplom kamplom force-pushed the wayland_viewport_src_size_fix branch from 70b3d28 to 00cd20a Compare March 21, 2024 16:37
@kamplom
Copy link
Contributor Author

kamplom commented Mar 21, 2024

Should be OK now. Thanks for taking your time to explain the proper way to do it, and sorry for the inconvenience

@gnif gnif merged commit a626a11 into gnif:master Mar 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client window fails to open under Wayland with scaling enabled
2 participants